gh-109587: Allow "precompiled" perf-trampolines to largely mitigate the cost of enabling perf-trampolines#109666
Merged
pablogsal merged 32 commits intopython:mainfrom Oct 27, 2023
Merged
gh-109587: Allow "precompiled" perf-trampolines to largely mitigate the cost of enabling perf-trampolines#109666pablogsal merged 32 commits intopython:mainfrom
pablogsal merged 32 commits intopython:mainfrom
Conversation
Lib/test/test_stable_abi_ctypes.py
Outdated
Comment on lines
808
to
809
| "PyUnstable_PerfTrampoline_CompileCode", | ||
| "PyUnstable_PerfTrampoline_SetPersistAfterFork", |
carljm
reviewed
Sep 25, 2023
Contributor
|
@pablogsal , @gpshead Would love to hear your thoughts on this (whenever you get a chance to take a look) :) |
Contributor
|
Ok I resolved the merge conflict, but I think the new MacOS failure is unrelated. |
auto-merge was automatically disabled
October 19, 2023 19:06
Head branch was pushed to by a user without write access
Member
|
@gsallam We still have some failures in the Windows and macOS CI. I think this is because the symbol doesn't exist in those cases: |
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Oct 25, 2023
Summary: As titled. To be on sync with python/cpython#109666. Reviewed By: czardoz Differential Revision: D50329585 fbshipit-source-id: d4c52143216a1d9970196ad71ef656098be50120
Member
|
We still have some failing tests it seems |
Contributor
|
This approach is likely quite silly, but I don't have a Windows/Mac machine handy, so I'm kicking off these builds to test/debug. |
Contributor
|
I will look at this over the weekend on my Windows box, this trial-and-error is not an optimal way :) |
Member
Don't worry, I pushed a commit that should fix it |
Contributor
|
Thanks a lot @pablogsal! 😄 |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…gate the cost of enabling perf-trampolines (python#109666)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…gate the cost of enabling perf-trampolines (python#109666)
facebook-github-bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Dec 17, 2024
Summary: Straight up port of python/cpython#109666 Reviewed By: jbower-fb Differential Revision: D66118319 fbshipit-source-id: bd7d4181c16d35526f57500cebb6e16fc2df58aa
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Dec 17, 2024
Summary: Straight up port of python/cpython#109666 Reviewed By: jbower-fb Differential Revision: D66118319 fbshipit-source-id: bd7d4181c16d35526f57500cebb6e16fc2df58aa
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a proposal in #109587 to allow precompiled perf-trampolines. This would mitigate the costs of enabling perf-trampolines, such as the disk IO and memory overhead.
The proposal introduces two new C-API functions:
PyUnstable_PerfTrampoline_CompileCode(): Creates a new trampoline and registers it.PyUnstable_PerfTrampoline_SetPersistAfterFork(): Controls whether to re-initialize trampolines in child processes.These functions can be used by extension modules to initialize trampolines eagerly, after the application is "warmed up". This would make it possible to have perf-trampoline running in an always-enabled fashion.
Benefits for a forked multiprocess model: